Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Change archDimTracker text position depending on distance and scale values #4077

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

marioalexis84
Copy link
Member

@marioalexis84 marioalexis84 commented Nov 23, 2020

When the size of the text is similar to or greater than the length of the aid dimension line, there is an annoying overlap of both that makes reading difficult.
This change prevents this behavior by moving the text to an external position when necessary.
Also, avoid accessing inventor node fields on each function call acording to https://forum.freecadweb.org/viewtopic.php?f=10&t=26784&start=30#p219409

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:

  • Branch rebased on latest master git pull --rebase upstream master
  • Unit tests confirmed to pass by running ./bin/FreeCAD --run-test 0
  • Commit message is well-written
  • Commit message includes issue #<id> or fixes #<id> where <id> is the associated MantisBT issue id if one exists

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.19 Changelog Forum Thread.


@yorikvanhavre yorikvanhavre merged commit 711b444 into FreeCAD:master Nov 25, 2020
@marioalexis84 marioalexis84 deleted the draft-arch_dim_tracker branch March 24, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants