[TD] show balloon dialog on double-clicking #4272
Conversation
when adding GD&T statements as described in https://wiki.freecadweb.org/TechDraw_Geometric_dimensioning_and_tolerancing You will quickly get a lot of balloons and it is then very tiring to be forced to first select a balloon with a single-click in the drawing, then go to the model tree and there double-click to get the dialog. This PR also removes unused includes from the dialog code.
There was a problem hiding this comment.
This compiles, runs, and implements the feature as described. It's a very nice usability addition to TD balloons. I do note, however, that it only works when double-clicking on the bubble, and not on the leader line or end element. I don't think that's a deal-breaker for this PR, just an idea for future refinement.
This is a general design decision by TechDraw. A balloon can only be selected in the drawing by clicking on its body. I guess this is because a balloon needn't to have a leader line, symbol etc. You see the same behavior also for other TD elements, or example a dimensions can only be selected when you click on its value, not onto its lines. I think the TD behavior is reasonable since selecting by clicking onto a thin line is not useful at all since you need several clicks until you hit it. |
|
IIRC I am the one who started this "partial" select thing with Draft dimensions, and it was then copied to TD, but indeed today I don't really see why we couldn't activate an element by clicking just anywhere on it. At some point we could try to mend that. But yeah, no need to solve all of earth's problems at once ;) |
For TD one often has dimension and leader line crossing each other. Therefore it is in my opinion better only to select via the body of the element (labels, text or whatever). Then it is clear what element should be addressed. |
|
Good point, but this is the same problem anywhere in the CAD world where lines cross... Indeed it's easy to select wrongly. |
When adding GD&T statements as described in
https://wiki.freecadweb.org/TechDraw_Geometric_dimensioning_and_tolerancing#Geometrical_Tolerancing
you will quickly get a lot of balloons and it is then very tiring to be forced to first select a balloon with a single-click in the drawing, then go to the model tree and there double-click to get the dialog.
With this PR you can directly double-click in the drawing to open the dialog directly.
This PR also removes unused includes from the dialog code.