Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arch] Fixed typo in Arch_Schedule #4303

Merged
merged 1 commit into from Jan 25, 2021

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Jan 22, 2021

Typo fix

@hyarion
Copy link
Contributor

hyarion commented Jan 22, 2021

@Roy-043 Nice catch!
Do you have any example where this change fixes an issue?

@abdullahtahiriyo abdullahtahiriyo changed the title Fixed typo in Arch_Schedule [Arch] Fixed typo in Arch_Schedule Jan 23, 2021
@Roy-043
Copy link
Contributor Author

Roy-043 commented Jan 25, 2021

The type->ifctype conversion is there for compatibility reasons. Without it many schedules created with a previous version of the code would have to be edited. But 'type' should not be used in new schedules.

Here is the related forum discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=53934

I have also edited the documentation a bit. But that still requires more work:
https://wiki.freecadweb.org/Arch_Schedule

@yorikvanhavre
Copy link
Member

Thanks!!

@yorikvanhavre yorikvanhavre merged commit 5d924dd into FreeCAD:master Jan 25, 2021
@Roy-043 Roy-043 deleted the Arch_Schedule_Typo_Fix branch January 25, 2021 13:09
wwmayer added a commit to wwmayer/FreeCAD that referenced this pull request Feb 25, 2021
wwmayer added a commit that referenced this pull request Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants