New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Add missing backwards-compatibility var #4598

Merged

wwmayer merged 1 commit into FreeCAD:master from chennes:cmakeAddMissingVariable

Mar 8, 2021

Member

chennes commented Mar 7, 2021

I missed a backwards-compatibility variable in the code handling CMake >=3.12 Python executables. This adds it.

Your pull request is confined strictly to a single module.
Small change
Your branch is rebased on latest master git pull --rebase upstream master
All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
All commit messages are well-written ex: Fixes typo in Draft Move command text
Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
No ticket


          [CMake] Add missing backwards-compatibility var

luzpaz assigned wwmayer

wwmayer merged commit e2782d0 into FreeCAD:master

chennes deleted the cmakeAddMissingVariable branch

March 8, 2021 15:40

wwmayer added a commit that referenced this pull request


          TD: fixes #4598: Segfault when deleting template without page

5e73e71

wwmayer added a commit that referenced this pull request


          TD: fixes #4598: Segfault when deleting template without page

e239684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet