Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PartDesign] Translation fixes for reported issues in FreeCAD-translations #4850

Merged
merged 3 commits into from Jun 22, 2021

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Jun 10, 2021

Attempt to fix pending bugs reported in several ticket on https://github.com/FreeCAD/FreeCAD-translations/issues

@luzpaz luzpaz added the Translation Translation and localization related label Jun 10, 2021
Copy link
Member

@yorikvanhavre yorikvanhavre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool... What is the reason for the // lines?

@luzpaz
Copy link
Contributor Author

luzpaz commented Jun 10, 2021

@yorikvanhavre I was following @berndhahnebach lead in the Fem Workbench.cpp specifically:
https://github.com/FreeCAD/FreeCAD/blob/master/src/Mod/Fem/Gui/Workbench.cpp#L37-L73

He parses out the list by how they are situated in the dropdown GUI. This is useful to make the formatting of Workbench.cpp a little more intuitive, IMHO.

image

@luzpaz
Copy link
Contributor Author

luzpaz commented Jun 16, 2021

@yorikvanhavre if you don't mind, please make a crowdin push/pull after merging this. Thanks!

@luzpaz
Copy link
Contributor Author

luzpaz commented Jun 17, 2021

7c5f8d8
69b084f
🤦

@yorikvanhavre yorikvanhavre merged commit c46036a into FreeCAD:master Jun 22, 2021
@luzpaz luzpaz deleted the crowdin/PD-fixes branch August 10, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Translation Translation and localization related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants