Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartDesign: Hide the custom direction fields in Pad if no custom direction is used #4872

Merged
merged 1 commit into from Aug 23, 2021

Conversation

berberic2
Copy link
Contributor

@berberic2 berberic2 commented Jun 19, 2021

PartDesign: Hide the custom direction fields if no custom direction is used

This is a minor UI-only patch to unclutter the PartDesign Pad UI. It hides the direction fields if no custom direction is used.

see https://forum.freecadweb.org/viewtopic.php?style=5&p=507878#p507852 for (no) discussions and screenshots.

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@berberic2 berberic2 changed the title PartDesign Pad UI-fix PartDesign: Pad UI-fix Jun 19, 2021
@berberic2 berberic2 changed the title PartDesign: Pad UI-fix PartDesign: Hide the custom direction fields if no custom direction is used Jun 19, 2021
@berberic2 berberic2 changed the title PartDesign: Hide the custom direction fields if no custom direction is used PartDesign: Hide the custom direction fields in Pad if no custom direction is used Jul 1, 2021
@berndhahnebach berndhahnebach added the WB Part Design Related to the Part Design Workbench label Jul 9, 2021
hide the custom direction fields if no custom direction is used, to
unclutter the UI.
Copy link
Member

@chennes chennes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This compiles, runs, and behaves as expected. I think it's a good change.

@yorikvanhavre yorikvanhavre merged commit d0de628 into FreeCAD:master Aug 23, 2021
@berberic2 berberic2 deleted the PD_pad_ui_change branch August 25, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Part Design Related to the Part Design Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants