Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Fix misplaced Draft_Edit nodes for BezCurve 2nd version #4891

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Jun 26, 2021

The poles in the resetTrackersBezier function are in the CS of the geometric parent of the curve. Before using p = obj.getGlobalPlacement().multVec(p) the nodes have to be translated to the CS of the curve. Otherwise the effects of the curve's Placement are added twice. See discussion: #4889

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


The poles in the resetTrackersBezier function are in the CS of the geometric parent of the curve. Before using `p = obj.getGlobalPlacement().multVec(p)` the nodes have to be translated to the CS of the curve. Otherwise the effects of the curve's Placement would be added twice. See discussion: FreeCAD#4889



 the global coordinate system. They should therefore not be translated from the LCS to the GCS.
Copy link
Contributor

@carlopav carlopav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks god to me!

@luzpaz
Copy link
Contributor

luzpaz commented Jun 26, 2021

@Roy-043 splitting hairs here but do you mind omitting 2nd version from the git commit title? It's extraneous and could be confusing out of context when reading the git log history. TIA

@berndhahnebach berndhahnebach added the WB Draft Related to the Draft Workbench label Jul 9, 2021
@yorikvanhavre yorikvanhavre merged commit 854fc52 into FreeCAD:master Sep 2, 2021
@Roy-043 Roy-043 deleted the Draft_Fix_Misplaced_Edit_Nodes_BezCurve_2 branch September 2, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Draft Related to the Draft Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants