Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ArchWall] Fix MakeBlocks to work if Base is Sketch #4955

Merged
merged 1 commit into from Aug 16, 2021
Merged

[ArchWall] Fix MakeBlocks to work if Base is Sketch #4955

merged 1 commit into from Aug 16, 2021

Conversation

paullee0
Copy link
Contributor

@paullee0 paullee0 commented Aug 5, 2021

Forum Discussion - https://forum.freecadweb.org/viewtopic.php?f=23&t=60771

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@luzpaz luzpaz added the WB Arch Related to the Arch Workbench label Aug 5, 2021
@paullee0
Copy link
Contributor Author

paullee0 commented Aug 9, 2021

To be merged with #4958

@yorikvanhavre yorikvanhavre merged commit 54f7486 into FreeCAD:master Aug 16, 2021
realthunder pushed a commit to realthunder/FreeCAD that referenced this pull request Oct 17, 2021
realthunder pushed a commit to realthunder/FreeCAD that referenced this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Arch Related to the Arch Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants