[Gui] Add hidden pref to lock toolbars #4992
Conversation
luzpaz
added
Core
When arranged vertically, the bar that allows the dragging of toolbars can cause problems with the toolbar appearance. This adds a hidden preference that controls whether the toolbars are movable.
chennes
force-pushed
the
hiddenPrefToLockToolbars
branch
from
00522f0
to
c1f7407
Compare
|
Compiled and tested, works really good to me. |
I can address that in this PR by adding code to Draft that checks for this hidden parameter when it creates its toolbars. I don't like that any other Python workbench that adds toolbars would have to do the same thing, though. But I cannot see a way around it as things are currently structured: there is no signal emitted when a toolbar is added, that I can find, so I can't think of a good way to enforce this behavior.
I suggest submitting that as a feature request ticket, it should be possible without too much trouble. |
I agree, perhaps I can find a way to turn those toolbars into standard ones... I'd suggest to leave this PR like this, but i'd like if we could continue this discussion here: https://forum.freecadweb.org/viewtopic.php?f=23&t=61715&p=528537#p528537
Ok, thanks! |
|
I understand you want to add more commits to this PR, @chennes ? Or do you prefer to merge it as is? |
Sorry for the confusion - this PR is done and ready, but there will be more in this series. |
|
would you rebase to make CI passing ... https://gitlab.com/berndhahnebach/FreeCAD/-/pipelines/376366855 |
|
would you rebase the PR to make it run on CI? |
Not yet, let me update it before as requested, not necessary to compile it now (same for the others PR where you asked). Let me know if compiling is necessary for some other tests of yours :) |
|
Following a link to the branch on the CI-repository: https://gitlab.com/berndhahnebach/FreeCAD/-/commits/PR_5060 The CI-status is available on the latest commit of the branch. https://gitlab.com/berndhahnebach/FreeCAD/-/pipelines?scope=branches |
|
FreeCAD CI-repository: pipeline: status: all pipelines for each branch: |
This adds the Std_ToggleToolBarLock action mentioned in FreeCAD#4992. It is exposed in the context menu of toolbar and also in the view -> toolbars app menu.
This adds the Std_ToggleToolBarLock action mentioned in #4992. It is exposed in the context menu of toolbar and also in the view -> toolbars app menu.
When arranged vertically, the bar that allows the dragging of toolbars can cause problems with the toolbar appearance. This adds a hidden preference that controls whether the toolbars are movable. This exists primarily to assist theme designers, and forms part of a larger set of changes adding hidden preferences to control various aspects of the GUI to allow more control over FreeCAD's appearance.