Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui: Group View Commands in View toolbar #4999

Closed
wants to merge 1 commit into from

Conversation

carlopav
Copy link
Contributor

@carlopav carlopav commented Aug 28, 2021

Group view commands by default in the view toolbar.
Since the introduction of the Navigation_Cube, the user have a quick way to change the view. Therefore there is not the necessity anymore to have 7 view buttons in the toolbar to access the functions that are easily usable through the Navigation_Cube.
Grouping them under a common goes in the direction of saving real estate in the FreeCAD window.

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@carlopav carlopav marked this pull request as draft August 28, 2021 16:30
@yorikvanhavre
Copy link
Member

I have some doubts about this, because the very idea of having these buttons in a toolbar is to have them explicitly shown so it's a one-click to switch from one view to another. Given that the navicube can be turned off, this bar then takes all its sense...

I would suggest doing something else, then: Isolate them in a separate toolbar, so a user can simply turn it off. What do you think?

@yorikvanhavre yorikvanhavre self-assigned this Aug 30, 2021
@carlopav
Copy link
Contributor Author

I think this is a good idea! I think I can change it if you want. I should be up to the task :)

@yorikvanhavre
Copy link
Member

Your baby now 😎

@luzpaz luzpaz added the Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label Sep 2, 2021
@berndhahnebach
Copy link
Contributor

would you rebase the PR to make it run on CI?

@berndhahnebach
Copy link
Contributor

Following a link to the branch on the CI-repository:

https://gitlab.com/berndhahnebach/FreeCAD/-/commits/PR_5060

The CI-status is available on the latest commit of the branch.
If there is no status available the PR should be rebased on latest master.
Check pipeline branches to see if your PR has been run by the CI.

https://gitlab.com/berndhahnebach/FreeCAD/-/pipelines?scope=branches

Group view commands by default in the view toolbar.
@berndhahnebach
Copy link
Contributor

@carlopav
Copy link
Contributor Author

I kept thinking about this change, and perhaps I was too hasty to PR it. Let's leave as it is now for the moment, at the end some more icons are not too problematic for the overall user experience...

@carlopav carlopav closed this Oct 13, 2021
@yorikvanhavre
Copy link
Member

Okay! Let's keep this in a corner of our minds though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants