New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gui: Group View Commands in View toolbar #4999
Conversation
I have some doubts about this, because the very idea of having these buttons in a toolbar is to have them explicitly shown so it's a one-click to switch from one view to another. Given that the navicube can be turned off, this bar then takes all its sense... I would suggest doing something else, then: Isolate them in a separate toolbar, so a user can simply turn it off. What do you think? |
I think this is a good idea! I think I can change it if you want. I should be up to the task :) |
Your baby now 😎 |
would you rebase the PR to make it run on CI? |
Following a link to the branch on the CI-repository: https://gitlab.com/berndhahnebach/FreeCAD/-/commits/PR_5060 The CI-status is available on the latest commit of the branch. https://gitlab.com/berndhahnebach/FreeCAD/-/pipelines?scope=branches |
Group view commands by default in the view toolbar.
c269229
to
f30728d
Compare
FreeCAD CI-repository: pipeline: status: all pipelines for each branch: |
I kept thinking about this change, and perhaps I was too hasty to PR it. Let's leave as it is now for the moment, at the end some more icons are not too problematic for the overall user experience... |
Okay! Let's keep this in a corner of our minds though |
Group view commands by default in the view toolbar.
Since the introduction of the Navigation_Cube, the user have a quick way to change the view. Therefore there is not the necessity anymore to have 7 view buttons in the toolbar to access the functions that are easily usable through the Navigation_Cube.
Grouping them under a common goes in the direction of saving real estate in the FreeCAD window.
Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!
App
,Base
,Gui
or one of theMod
subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next onesgit pull --rebase upstream master
./bin/FreeCAD --run-test 0
Fixes typo in Draft Move command text
Draft: Fixed typos
issue #<id>
orfixes #<id>
where<id>
is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex:Draft: fix typos - fixes #0004805
And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.