Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Rotation : fix gimbal lock handling #5027

Merged
merged 1 commit into from Sep 14, 2021

Conversation

0penBrain
Copy link
Contributor

  • fix Euler representation string on GUI

Forum discussion

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0 I tested specifically the fix only
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

@luzpaz luzpaz added the Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label Sep 12, 2021
@yorikvanhavre
Copy link
Member

In that case I feel the following 3 fields should also be inverted...
Screenshot from 2021-09-13 11-15-03
Won't ZYX be confusing for many users? If we talk about 3 axes, the logical sequence 99% of users will think of is XYZ. Shouldn't we somehow, make it clearer that XYZ does NOT translate to yaw-pitch-roll? For ex in the drop down list, be able to switch?

@0penBrain
Copy link
Contributor Author

@yorikvanhavre this is quite a complicated topic to me. It really depends what is your knowledge and understanding about Euler angles. I'll do a proposal later this day.

 + fix Euler representation on GUI
@0penBrain
Copy link
Contributor Author

Now how it looks like :
image

@yorikvanhavre
Copy link
Member

That looks pefect! Totally understandable by everybody. Thanks!!

@yorikvanhavre yorikvanhavre merged commit 381f835 into FreeCAD:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants