New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plot: Expose src/Mod/Plot strings to translation #5042
Conversation
In order to have updatets.py create the appropriate TS files, we'll need to add a Resources/translations directory as well, and presumably update the CMakeLists.txt file to do something with it. |
@chennes other workbenches have a put |
The mods that do that have separate App and Gui directories. But we do have several that don't: I think Addon Manager, Arch, and Draft all simply use Resources. That said, I don't actually care either way. |
would you rebase the PR to make it run on CI? |
Following a link to the branch on the CI-repository: https://gitlab.com/freecad/FreeCAD-CI/-/commits/PR_5042 The CI-status is available on the latest commit of the branch. https://gitlab.com/freecad/FreeCAD-CI/-/pipelines?scope=branches |
I'm actually not certain what to do here since plot has been removed from core and made in to an addon. I've notated FreeCAD/FreeCAD-translations#60 and pinged @sanguinariojoe to get more clarity |
for feature branch PR_5042. Pipeline #393584845 was triggered at 284c674. All CI branch pipelines. |
This PR basically doesn't modify anything anymore (just whitespaces/line fixes)... We could merge it already. Mind to remove the "draft" status @luzpaz ? |
@yorikvanhavre I've marked for review and rebased. What do we do about FreeCAD/FreeCAD-translations#60 ? Is it not an issue anymore? |
@yorikvanhavre I should prob. rename this commit then, right? (ref: #5042 (comment)) |
approved by yorik -> merging |
Closes FreeCAD/FreeCAD-translations#60
Also relies on #5037 to add Plot to the Crowdin
updatets.py
script