Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot: Expose src/Mod/Plot strings to translation #5042

Merged
merged 2 commits into from Jan 6, 2022

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Sep 18, 2021

Closes FreeCAD/FreeCAD-translations#60

Also relies on #5037 to add Plot to the Crowdin updatets.py script

@luzpaz luzpaz added the Translation Translation and localization related label Sep 18, 2021
@luzpaz luzpaz marked this pull request as draft September 18, 2021 14:12
@chennes
Copy link
Member

chennes commented Sep 18, 2021

In order to have updatets.py create the appropriate TS files, we'll need to add a Resources/translations directory as well, and presumably update the CMakeLists.txt file to do something with it.

@luzpaz
Copy link
Contributor Author

luzpaz commented Sep 18, 2021

@chennes other workbenches have a put Resources/translations/ within their Gui/ directory. So should we appropriately create Gui/Resources/translations/ then?

@chennes
Copy link
Member

chennes commented Sep 18, 2021

The mods that do that have separate App and Gui directories. But we do have several that don't: I think Addon Manager, Arch, and Draft all simply use Resources. That said, I don't actually care either way.

@berndhahnebach
Copy link
Contributor

would you rebase the PR to make it run on CI?

@berndhahnebach
Copy link
Contributor

Following a link to the branch on the CI-repository:

https://gitlab.com/freecad/FreeCAD-CI/-/commits/PR_5042

The CI-status is available on the latest commit of the branch.
If there is no status available the PR should be rebased on latest master.
Check pipeline branches to see if your PR has been run by the CI.

https://gitlab.com/freecad/FreeCAD-CI/-/pipelines?scope=branches

@luzpaz
Copy link
Contributor Author

luzpaz commented Oct 21, 2021

I'm actually not certain what to do here since plot has been removed from core and made in to an addon. I've notated FreeCAD/FreeCAD-translations#60 and pinged @sanguinariojoe to get more clarity

@freecadci
Copy link

pipeline statusfor feature branch PR_5042. Pipeline #393584845 was triggered at 284c674. All CI branch pipelines.

@yorikvanhavre
Copy link
Member

This PR basically doesn't modify anything anymore (just whitespaces/line fixes)... We could merge it already. Mind to remove the "draft" status @luzpaz ?

@luzpaz luzpaz marked this pull request as ready for review December 4, 2021 18:12
@luzpaz
Copy link
Contributor Author

luzpaz commented Dec 4, 2021

@yorikvanhavre I've marked for review and rebased. What do we do about FreeCAD/FreeCAD-translations#60 ? Is it not an issue anymore?

@freecadci
Copy link

pipeline status for feature branch PR_5042. Pipeline 423701021 was triggered at e6ccc5c. All CI branches and pipelines.

@luzpaz
Copy link
Contributor Author

luzpaz commented Dec 7, 2021

@yorikvanhavre I should prob. rename this commit then, right? (ref: #5042 (comment))

@donovaly
Copy link
Member

donovaly commented Jan 6, 2022

approved by yorik -> merging

@donovaly donovaly merged commit b699096 into FreeCAD:master Jan 6, 2022
@luzpaz luzpaz deleted the Crowdin-Plot branch January 7, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Translation Translation and localization related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot → main menu / Plot
6 participants