New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fem] Clean up Fem.ts to remove extra translations #5078
[Fem] Clean up Fem.ts to remove extra translations #5078
Conversation
6a3eda9
to
f469b70
Compare
Great work. Will shortly explain. Fem.ts contained:
etc...
And this caused an error when lupdate update Fem.ts file. As a result, new lines were not added to Fem.ts. |
for feature branch PR_5078. Pipeline #380452654 was triggered at ef7127a. All CI branch pipelines. |
Waiting for the request is merged and @yorikvanhavre to update Crowdin build again. |
Despite it is FEM I can not say much since I do not know much about FreeCAD translation system. Means if the translation core devs are fine it is fine for me too. |
Since @yorikvanhavre is the one who can upload the new strings to CrowdIn I think it makes the most sense to leave this to him. |
@berndhahnebach there is no other way, this mistake would have to be corrected sooner or later. I think everything should be normal. |
for feature branch PR_5078. Pipeline #384011477 was triggered at 4bb4203. All CI branch pipelines. |
for feature branch PR_5078. Pipeline #384021791 was triggered at ef7127a. All CI branch pipelines. |
Ok this looks good! I'm merging and I'll do a crowdin update right after |
Fem.ts was not being updated by
lupdate
because it had extraneous translations in it. This PR removes those, and contains the full successful results of the unified C++ and Pythonlupdate
runs.Edited to add: I've also added a
sed
script to ourtsupdate.py
tool to strip out those translations if they occur in the future.