Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fem] Clean up Fem.ts to remove extra translations #5078

Merged
merged 2 commits into from Oct 8, 2021

Conversation

chennes
Copy link
Member

@chennes chennes commented Sep 30, 2021

Fem.ts was not being updated by lupdate because it had extraneous translations in it. This PR removes those, and contains the full successful results of the unified C++ and Python lupdate runs.

Edited to add: I've also added a sed script to our tsupdate.py tool to strip out those translations if they occur in the future.

@chennes chennes added Translation Translation and localization related WB FEM Related to the FEM Workbench labels Sep 30, 2021
@FreeCAD-Tools
Copy link
Contributor

FreeCAD-Tools commented Sep 30, 2021

Great work.

Will shortly explain. Fem.ts contained:

  <source>Fem</source>
  <translation>Fem</translation>

etc...
instead:

  <source>Fem</source>
  <translation type="unfinished"></translation>

And this caused an error when lupdate update Fem.ts file. As a result, new lines were not added to Fem.ts.

@freecadci
Copy link

pipeline status for feature branch PR_5078. Pipeline #380452654 was triggered at ef7127a. All CI branch pipelines.

@FreeCAD-Tools
Copy link
Contributor

Waiting for the request is merged and @yorikvanhavre to update Crowdin build again.

@berndhahnebach
Copy link
Contributor

Despite it is FEM I can not say much since I do not know much about FreeCAD translation system. Means if the translation core devs are fine it is fine for me too.

@chennes
Copy link
Member Author

chennes commented Oct 4, 2021

Since @yorikvanhavre is the one who can upload the new strings to CrowdIn I think it makes the most sense to leave this to him.

@FreeCAD-Tools
Copy link
Contributor

@berndhahnebach there is no other way, this mistake would have to be corrected sooner or later. I think everything should be normal.

@freecadci
Copy link

pipeline status for feature branch PR_5078. Pipeline #384011477 was triggered at 4bb4203. All CI branch pipelines.

@freecadci
Copy link

pipeline status for feature branch PR_5078. Pipeline #384021791 was triggered at ef7127a. All CI branch pipelines.

@yorikvanhavre
Copy link
Member

Ok this looks good! I'm merging and I'll do a crowdin update right after

@yorikvanhavre yorikvanhavre merged commit 7489e8e into FreeCAD:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Translation Translation and localization related WB FEM Related to the FEM Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants