Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft housekeeping: import is_group and get_windows in Draft.py #5178

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Nov 16, 2021

Seems logical to include these new functions.

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@freecadci
Copy link

pipeline status for feature branch PR_5178. Pipeline 411475577 was triggered at a70d4a5. All CI branches and pipelines.

@yorikvanhavre
Copy link
Member

missing commas ;)

getGroupNames,
ungroup,
get_windows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
get_windows
rom draftutils.groups import (is_group,
get_group_names,
getGroupNames,
ungroup,
get_windows,

Fixed missing commas.
@Roy-043
Copy link
Contributor Author

Roy-043 commented Nov 24, 2021

Good catch. I should have tested... Fixed now.

@freecadci
Copy link

pipeline status for feature branch PR_5178. Pipeline 417423098 was triggered at 401db10. All CI branches and pipelines.

@donovaly donovaly added the WB Draft Related to the Draft Workbench label Nov 29, 2021
@yorikvanhavre yorikvanhavre merged commit b28ff5b into FreeCAD:master Dec 1, 2021
@yorikvanhavre
Copy link
Member

Thanks!

@Roy-043 Roy-043 deleted the Draft-housekeeping-import-is_group-get_windows branch December 2, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Draft Related to the Draft Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants