Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: fix array issue with Draft_Point and Part_Vertex. #5180

Merged

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Nov 16, 2021

When the shape of a Draft_Point or Part_Vertex is copied the Placement of the copy does not match that of the original shape. Resetting the Placement is then problematic. We need to use transformGeometry.

Forum topics:
https://forum.freecadweb.org/viewtopic.php?f=3&t=63591
https://forum.freecadweb.org/viewtopic.php?f=22&t=63672

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@freecadci
Copy link

pipeline status for feature branch PR_5180. Pipeline 411475583 was triggered at f548494. All CI branches and pipelines.

@yorikvanhavre yorikvanhavre merged commit 643460e into FreeCAD:master Nov 24, 2021
@Roy-043 Roy-043 deleted the Draft-fix-draft-point-array-issue branch November 25, 2021 14:17
Roy-043 added a commit to Roy-043/FreeCAD that referenced this pull request Dec 3, 2021
This PR fixes a regression introduces with FreeCAD#5180.
@Roy-043 Roy-043 mentioned this pull request Dec 3, 2021
7 tasks
chennes pushed a commit that referenced this pull request Dec 8, 2021
* Draft: fix regression draftlink.py

This PR fixes a regression introduces with #5180.

Using transformShape is the correct solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants