Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: fix toggle grid issue. #5183

Merged
merged 1 commit into from Nov 24, 2021

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Nov 17, 2021

Draft_ToggleGrid did not work when a command was active. The code that was removed, intended (I think) to immediately display the grid in a new view, did not do that anyway.

If a new view is created the grid is not shown initially. The user has to start a command, or toggle the grid with the Draft_ToggleGrid command. This mod does not change that.

Forum topic: https://forum.freecadweb.org/viewtopic.php?f=23&t=60749

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@freecadci
Copy link

pipeline status for feature branch PR_5183. Pipeline 411476341 was triggered at 9a467f3. All CI branches and pipelines.

@yorikvanhavre
Copy link
Member

Ok looks good, let's test!

@yorikvanhavre yorikvanhavre merged commit 2d7e867 into FreeCAD:master Nov 24, 2021
@Roy-043 Roy-043 deleted the Draft-fix-toggle-grid branch November 25, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants