Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Draft_SetStyle and Draft_Layer did not handle PointColor and PointSize. #5206

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Nov 28, 2021

Draft_SetStyle and Draft_Layer did not handle PointColor and PointSize.

Additionally:

gui_setstyle.py:

  • Fixed the DisplayMode code which did not work as vobj.Proxy.getDisplayModes(vobj) returns an empty list for some reason.
  • Also set the DefaultShapeVertexColor parameter to the LineColor. This parameter works since Part: Fix default shape vertex color #4954. It is not used by the Draft WB. But updating the parameter does make sense from the perspective of the user I think.

view_layer.py:

  • Changed wrong use of _tr to translate as discussed in Draft: Fix merge layers #5130.
  • Removed FontColor as it is not used anywhere in the FreeCAD code.

Forum topic:
https://forum.freecadweb.org/viewtopic.php?f=23&t=59604

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


Draft_SetStyle did not handle PointColor and PointSize.
Draft_Layer did not handle PointColor and PointSize.
@freecadci
Copy link

pipeline status for feature branch PR_5206. Pipeline 417927125 was triggered at 5e0f8bf. All CI branches and pipelines.

@donovaly donovaly added the WB Draft Related to the Draft Workbench label Nov 29, 2021
@yorikvanhavre
Copy link
Member

Perfect fix! Thanks!!

@yorikvanhavre yorikvanhavre merged commit 114fe73 into FreeCAD:master Dec 1, 2021
@Roy-043 Roy-043 deleted the Draft-fix-layer-and-style-handling-of-point-color-and-point-size branch December 2, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Draft Related to the Draft Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants