New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Fix translation issues #5370
Draft: Fix translation issues #5370
Conversation
Thanks... There are still many of those lingering, since the Great Draft Upgrade ;) |
JFYI, there are open Draft related translations issues in https://github.com/FreeCAD/FreeCAD-translations/issues?q=is%3Aissue+is%3Aopen+draft+label%3ADraft |
The CI failed. Can you please have a look? |
Note that some translation issues still remain: This whole translation business is a bit complex, but these issues are even more complex. The GUI elements involved are not 'normal' menus or toolbars. They will have to be addressed in a separate PR. |
The last commit should take care of the remaining translation issues. I have used a dictionary for the tooltips of the snapping commands. For the context I have used Note that in the Draft code both Minor refactoring: The |
There seems to be an issue with the |
@yorikvanhavre after this gets merged can you run a crowdin push/pull (so we can get these translations to see if the fix worked?) |
Yes, saw the "draft" vs "Draft" context issues already. Not sure what's the best way to solve this or if i is possible without disrupting translations... |
Does CrowdIn have any way to bulk-push translations up to it, from something like the translation TS files? |
PR to fix multiple translation issues. Mostly caused by the wrong context.
App
,Base
,Gui
or one of theMod
subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next onesgit pull --rebase upstream master
./bin/FreeCAD --run-test 0
Fixes typo in Draft Move command text
Draft: Fixed typos
issue #<id>
orfixes #<id>
where<id>
is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex:Draft: fix typos - fixes #0004805