Addon Manager: Switch to using QWebEngineView for README #5458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how to fix the conflict... Can you have a look @chennes ? I'd like to test this! |
chennes
force-pushed
the
addonManagerShowReadmeInWebView
branch
from
062b23a
to
57f9364
Compare
|
@yorikvanhavre Rebased, conflict should be gone now. Thanks for testing! |
|
"Rock 'n roll" |
|
That predated me, but I felt like I had to leave it in 😄 |
|
I gave it a test spin, pretty cool! One little thin I would do is add some padding so there is a little space between the HTML text contents and the widget border:
|
chennes
force-pushed
the
addonManagerShowReadmeInWebView
branch
from
57f9364
to
8eeb0f9
Compare
|
Good idea -- I've added 1em of padding inside the whole body in the cases where we are extracting the article element and reparenting it. This appears to work well for the four known git hosts. |
Rather than manually parsing the output from the repo's host, the Addon Manager now uses an embedded QWebEngineView to display the README data. This makes the display more repo-location agnostic (rather than trying to parse the specific code from GitHub, Gitlab, etc.). Special handling of known hosts is still provided to improve the display of the page, but it is not required. Clicking a link on the page still loads in a new system browser window, with the exception of links to the FreeCAD wiki, which are loaded in the same browser. This is expected to be used primarily to access traslated pages for Macros, so no advanced web-browsing features are displayed (e.g. back buttons, history access, etc.).
chennes
force-pushed
the
addonManagerShowReadmeInWebView
branch
from
8eeb0f9
to
e15ac44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take Two -- some different design decisions this time. The basic idea is to use QWebEngineView (which is basically a fork of Chromium) to display the README and Macro Wiki Page content, since that content is really web-based and makes sense in a web browser. However, it is not intended as a general purpose web browser: almost all links you click on will ask the system to open its default web browser, the same way the original version did. The only exception is FreeCAD wiki pages, which this web view will render.