Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch: Fix ArchFrame #5479

Merged
merged 1 commit into from Feb 3, 2022
Merged

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Feb 2, 2022

A previous PR broke ArchFrame for non planar Base objects (single lines).

This PR fixes this and also simplifies the alignment algo by relying on the built-in capabilities of FreeCAD.Rotation(). The resulting alignments are more logical in general.

Additionally:

  • The first Base Point now matches the Placement.Base of the profile. This makes more sense than using the CenterOfMass of its face.
  • Offset is performed before Rotation. Again because this makes more sense.
  • Replaced obj.Profile.isDerivedFrom("Part::Part2DObject") check with obj.Profile.Shape.findPlane() check. The latter is more reliable and flexible. A Part::Part2DObject does not have to be planar. And f.e. a Std_Part that contains a profile can now be used.

Forum topics:
https://forum.freecadweb.org/viewtopic.php?f=23&t=65266
https://forum.freecadweb.org/viewtopic.php?f=23&t=65342

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@github-actions github-actions bot added the WB Arch Related to the Arch Workbench label Feb 2, 2022
@freecadci
Copy link

pipeline status for feature branch PR_5479. Pipeline 462151172 was triggered at 10c49de. All CI branches and pipelines.

@yorikvanhavre
Copy link
Member

Thanks for the follow-up!
I didn't test yet but will do!

@yorikvanhavre yorikvanhavre merged commit 9eb69d2 into FreeCAD:master Feb 3, 2022
@Roy-043 Roy-043 deleted the Arch-Fix-ArchFrame branch February 9, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Arch Related to the Arch Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants