Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch: ArchWindow.py fix alignment of library windows #5485

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Feb 2, 2022

Windows and doors from parts_library were not aligned with or inserted in a wall.

Additionally:
The existing code for presetdir never worked. I have solved this by treating presetdir the same as librarypath. So the same directory structure is expected in both paths. I think this makes the most sense.

Forum topic:
https://forum.freecadweb.org/viewtopic.php?f=23&t=65210

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

Windows and doors from parts_library were not aligned with or inserted in a wall.
@github-actions github-actions bot added the WB Arch Related to the Arch Workbench label Feb 2, 2022
@freecadci
Copy link

pipeline status for feature branch PR_5485. Pipeline 462153093 was triggered at 129005d. All CI branches and pipelines.

@yorikvanhavre
Copy link
Member

Ok good to go! Thanks!

@yorikvanhavre yorikvanhavre merged commit 32fdcc6 into FreeCAD:master Feb 11, 2022
@Roy-043 Roy-043 deleted the Arch-ArchWindow.py-fix-alignment-of-library-windows branch February 11, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Arch Related to the Arch Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants