Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD: Fix w[z] plot in ShaftWizard #6954

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

chennes
Copy link
Member

@chennes chennes commented Jun 1, 2022

This PR uncomments a chunk of code that appears to have been erroneously removed based on static analysis. That code was responsible for calculating the data used to plot the translation data, and removing it broke that plot function.

@chennes chennes requested a review from donovaly June 1, 2022 22:23
@github-actions github-actions bot added the Mod: Part Design Related to the Part Design Workbench label Jun 1, 2022
@freecadci
Copy link

pipeline status for feature branch PR_6954. Pipeline 553657559 was triggered at b9ceda0. All CI branches and pipelines.

@donovaly
Copy link
Member

donovaly commented Jun 1, 2022

Thanks. This fixes the issue for me. I get now a correct plot with sensible data.

@chennes chennes merged commit d860c4b into FreeCAD:master Jun 1, 2022
@chennes chennes deleted the fixPDShaftWizardWzPlot branch June 1, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: Part Design Related to the Part Design Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants