-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gui] QSint: fix QGroupBox visibility #7292
Conversation
- the point is that we don't set any style for the group boxes, therefore the Windows style is applied as nothing was set yet. The default Windows style is the color #dddddd which is hardly visible on our blue default style. as solution set an explicit color.
cb01b62
to
b62e9d0
Compare
Thanks for working on this, and fixing the true cause of the issue. |
@Roy-043 , I am a bit reluctant about the border color. What is in your opinion better?: (left is |
@donovaly should we let the FreeCAD theme-ers know about this ? (ie FreeCAD/FreeCAD-addons#201) |
This is not necessary since the various themes use their own style. The fix here is only for the default style - meaning when no style file is applied. What is your opinion, better the left or right image? |
Right side. |
I prefer the left image. On the right the contrast is too low IMO. |
I like the left one better, but modern style is to make everything gray on light gray on off-white on white. Very low constrast is the current fad. Great for teenagers; not so great for more "mature" folks. |
Thanks for the feedback. I made a mistake here: for years nobody really cared and now I triggered a discussion about the right color for a box line. This is not really worth it. @Roy-043 was insisting that the issue got fixed, so shall it be his choice: :-) -> merging the PR is it is. |
as solution set an explicit color and use the grooved style.
This is the result: