Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Improve In-Command-shortcut Undo implementation #7359

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Aug 13, 2022

This PR improves 5a9201d

The inCommandShortcutNearSnap shortcut did not work and was removed. Using Near snap should be discouraged anyway.

Additionally:
To improve the layout spacers were added to the ui file.
Preferences_Draft_Tab_User_interface_settings_new

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex: Draft: fix typos - fixes #4805

@github-actions github-actions bot added the WB Draft Related to the Draft Workbench label Aug 13, 2022
Roy-043 referenced this pull request Aug 13, 2022
That shortcut had apparently been left out last time the system was recoded..
I used the default shortcut '/' because Ctrl doesn't really work with the
current system, and Z is already taken
@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7359. Pipeline 612682471 was triggered at 2ca31f5. All CI branches and pipelines.

@yorikvanhavre
Copy link
Member

Using Near snap should be discouraged anyway

It still has its uses... I use it now and there.

@Roy-043
Copy link
Contributor Author

Roy-043 commented Sep 5, 2022

Yes Draft Snap Near certainly has its purposes. But it does not deserve an In-Command shortcut IMO (and the existing shortcut did not work anyway).

@Roy-043
Copy link
Contributor Author

Roy-043 commented Sep 9, 2022

Are the failed checks blocking this PR? The checks seem old and to be caused by other PRs AFAICT. Is there a way to trigger updated checks?

@luzpaz
Copy link
Contributor

luzpaz commented Sep 9, 2022

Can you rebase in order to re-trigger CI. But you may want to wait until #7469 is merged

@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7359. Pipeline 636918424 was triggered at 6da561e. All CI branches and pipelines.

@Roy-043
Copy link
Contributor Author

Roy-043 commented Sep 16, 2022

@yorikvanhavre IMO this PR can be merged. Please let me know if there are any issues.

@yorikvanhavre
Copy link
Member

Sorry guys, this one fell out of my radar. Ok, let's merge this, we see about fixing the snap near shortcut later on...

@yorikvanhavre yorikvanhavre merged commit f26260e into FreeCAD:master Sep 21, 2022
@Roy-043 Roy-043 deleted the Draft-Improve-In-Command-shortcut-Undo-implementation branch September 21, 2022 11:03
@Roy-043
Copy link
Contributor Author

Roy-043 commented Sep 21, 2022

@donovaly Since this PR improves a PR that was backported, it would make sense to also backport this one. Thanks.

donovaly pushed a commit that referenced this pull request Sep 24, 2022
…ut-Undo-implementation

Draft: Improve In-Command-shortcut Undo implementation
@donovaly
Copy link
Member

@donovaly Since this PR improves a PR that was backported, it would make sense to also backport this one. Thanks.

Thank you. I backported it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Draft Related to the Draft Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants