New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Improve In-Command-shortcut Undo implementation #7359
Draft: Improve In-Command-shortcut Undo implementation #7359
Conversation
That shortcut had apparently been left out last time the system was recoded.. I used the default shortcut '/' because Ctrl doesn't really work with the current system, and Z is already taken
It still has its uses... I use it now and there. |
Yes Draft Snap Near certainly has its purposes. But it does not deserve an In-Command shortcut IMO (and the existing shortcut did not work anyway). |
Are the failed checks blocking this PR? The checks seem old and to be caused by other PRs AFAICT. Is there a way to trigger updated checks? |
Can you rebase in order to re-trigger CI. But you may want to wait until #7469 is merged |
…Undo-implementation
@yorikvanhavre IMO this PR can be merged. Please let me know if there are any issues. |
Sorry guys, this one fell out of my radar. Ok, let's merge this, we see about fixing the snap near shortcut later on... |
@donovaly Since this PR improves a PR that was backported, it would make sense to also backport this one. Thanks. |
…ut-Undo-implementation Draft: Improve In-Command-shortcut Undo implementation
Thank you. I backported it now. |
This PR improves 5a9201d
The
inCommandShortcutNearSnap
shortcut did not work and was removed. Using Near snap should be discouraged anyway.Additionally:
To improve the layout spacers were added to the ui file.
App
,Base
,Gui
or one of theMod
subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next onesgit pull --rebase upstream master
./bin/FreeCAD --run-test 0
Fixes typo in Draft Move command text
Draft: Fixed typos
issue #<id>
orfixes #<id>
where<id>
is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex:Draft: fix typos - fixes #4805