Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch: Fix wall baseface generation for overlapping and self-intersecting traces #7436

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Sep 3, 2022

To fix the issue a new argument, per_segment, was introduced for the bind function in faces.py. Additionally the call to face.fix() was moved to that function.

Fixes #7370

Forum topics:
https://forum.freecadweb.org/viewtopic.php?f=23&t=67107&start=30
https://forum.freecadweb.org/viewtopic.php?f=23&t=71107

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex: Draft: fix typos - fixes #4805

@github-actions github-actions bot added WB Arch Related to the Arch Workbench WB Draft Related to the Draft Workbench labels Sep 3, 2022
@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7436. Pipeline 630414837 was triggered at 8aaa36a. All CI branches and pipelines.

@yorikvanhavre
Copy link
Member

Amazing job!

@yorikvanhavre yorikvanhavre merged commit 0c8b50d into FreeCAD:master Sep 5, 2022
@Roy-043 Roy-043 deleted the Arch-Fix-baseface-generation-for-walls-with-a-trace-that-self-intersects,-has-T-connections-or-that-overlaps branch September 5, 2022 10:18
@Roy-043
Copy link
Contributor Author

Roy-043 commented Sep 12, 2022

@donovaly FYI: this bug fix can be backported.

@donovaly
Copy link
Member

Thanks, backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Arch Related to the Arch Workbench WB Draft Related to the Draft Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Arch Wall not visible when base sketch lines overlap
4 participants