Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Fix handling of double quotes in shapestrings #7558

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Oct 5, 2022

Double quotes in the task panel input string need to be escaped.

Forum topic:
https://forum.freecadweb.org/viewtopic.php?f=23&t=72342

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex: Draft: fix typos - fixes #4805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 1.0 Changelog Forum Thread.


@github-actions github-actions bot added the WB Draft Related to the Draft Workbench label Oct 5, 2022
@Roy-043 Roy-043 changed the title Draft: Fix handling of double quote in shapestring Draft: Fix handling of double quotes in shapestring Oct 5, 2022
@Roy-043 Roy-043 changed the title Draft: Fix handling of double quotes in shapestring Draft: Fix handling of double quotes in shapestrings Oct 5, 2022
@yorikvanhavre yorikvanhavre merged commit 3774ff7 into FreeCAD:master Oct 7, 2022
@Roy-043 Roy-043 deleted the Draft-Fix-handling-of-double-quote-in-shapestring branch October 7, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Draft Related to the Draft Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants