Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.20] History storage framework and options for select methods in TopoShapePy #868

Closed
wants to merge 11 commits into from

Conversation

AjinkyaDahale
Copy link
Contributor

@AjinkyaDahale AjinkyaDahale commented Jul 9, 2017

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:

  • Branch rebased on latest master git pull --rebase upstream master
  • Unit tests confirmed to pass by running ./bin/FreeCAD --run-test 0
  • Commit message is well-written
  • Commit message includes issue #<id> or fixes #<id> where <id> is the associated MantisBT issue id if one exists

And please remember to update the Wiki with the features added or changed once this PR once it is merged.


Some testing required. Works well enough for my test cases, but they are fairly naive.

Supported methods (all booleans, extrude, mirror, makeFillet2, makeChamfer2) now come with an optional withHistory parameter that can be set to True if you want to store history. The development of the sub-shapes from the sub-shapes of the base(s) can be studied by using shapeName.History.modified, shapeName.History.generated, shapeName.History.isDeleted.

@AjinkyaDahale AjinkyaDahale force-pushed the tnaming-pr branch 2 times, most recently from 782a20b to d3daf13 Compare July 11, 2017 04:34
@ezzieyguywuf
Copy link
Contributor

ezzieyguywuf commented Jul 19, 2017

I believe there is a typo on Line 72 in TopoHistory.cpp. Notice that this line refers to the shapeMaker->Modified method rather than the shapeMaker->Generated method as expected

@AjinkyaDahale
Copy link
Contributor Author

AjinkyaDahale commented Jul 19, 2017

@ezzieyguywuf You're right! wonder how that mistake got there, since I'm sure I had tested it.

@DeepSOIC
Copy link
Contributor

ezziey's thread, relevant to this PR. Just for record.
https://forum.freecadweb.org/viewtopic.php?p=183060&sid=25ffc700d68c60bf02d213366a9811a5#p183060

@luzpaz
Copy link
Contributor

luzpaz commented Aug 14, 2017

How is this GSOC project doing so far? Haven't seen any dialogue discussing integration.

@wwmayer wwmayer changed the title History storage framework and options for select methods in TopoShapePy [For v0.18]History storage framework and options for select methods in TopoShapePy Feb 7, 2018
@wwmayer wwmayer changed the title [For v0.18]History storage framework and options for select methods in TopoShapePy [For v0.19]History storage framework and options for select methods in TopoShapePy Feb 11, 2019
@yorikvanhavre yorikvanhavre added the ✋ On hold This PR must not be merged before some condition is met label Feb 18, 2019
@yorikvanhavre yorikvanhavre removed the ✋ On hold This PR must not be merged before some condition is met label Mar 22, 2019
@PrzemoF
Copy link
Contributor

PrzemoF commented Dec 15, 2020

Should we keep it here? It's 3 years old and even if the original idea worked it definitely needs rework. I suggest to add a label "rework needed" and close.

Edit: tag->label, thanks luzpaz

@luzpaz
Copy link
Contributor

luzpaz commented Dec 15, 2020

Sort of relevant. We could start labeling PRs

@DeepSOIC
Copy link
Contributor

I'm pretty sure it should be closed. Ajinkya is unlikely to return, and i'm not planning to advance it either. And we have a proven-to-work realthunder's implementation.

@AjinkyaDahale
Copy link
Contributor Author

Unfortunately, DeepSOIC is kinda correct. I did intend to get back to this but things got far too busy. I will have some time now, but I might not be able to be directly involved because reasons.

@yorikvanhavre yorikvanhavre changed the title [For v0.19]History storage framework and options for select methods in TopoShapePy [0.20] History storage framework and options for select methods in TopoShapePy Feb 5, 2021
@AjinkyaDahale
Copy link
Contributor Author

I think this can be closed since it's long been replaced by @realthunder's work.

@AjinkyaDahale AjinkyaDahale deleted the tnaming-pr branch February 25, 2022 22:42
@AjinkyaDahale AjinkyaDahale restored the tnaming-pr branch February 25, 2022 22:42
@AjinkyaDahale AjinkyaDahale deleted the tnaming-pr branch February 26, 2022 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants