New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.20] History storage framework and options for select methods in TopoShapePy #868
Conversation
782a20b
to
d3daf13
Compare
I believe there is a typo on Line 72 in TopoHistory.cpp. Notice that this line refers to the |
@ezzieyguywuf You're right! wonder how that mistake got there, since I'm sure I had tested it. |
ezziey's thread, relevant to this PR. Just for record. |
Fixed TopoShape-TopoHistory circular dependency issue courtesy DeepSOIC
Also has code changed in Part::Boolean to accomodate history storage in future
Now `modified` and `generated` return `std::vector<TopoShape>` instead of `TopTools_ListOfShape`
3401db0
to
41d27b2
Compare
How is this GSOC project doing so far? Haven't seen any dialogue discussing integration. |
Should we keep it here? It's 3 years old and even if the original idea worked it definitely needs rework. I suggest to add a label "rework needed" and close. Edit: tag->label, thanks luzpaz |
Sort of relevant. We could start labeling PRs |
I'm pretty sure it should be closed. Ajinkya is unlikely to return, and i'm not planning to advance it either. And we have a proven-to-work realthunder's implementation. |
Unfortunately, DeepSOIC is kinda correct. I did intend to get back to this but things got far too busy. I will have some time now, but I might not be able to be directly involved because reasons. |
I think this can be closed since it's long been replaced by @realthunder's work. |
Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:
git pull --rebase upstream master
./bin/FreeCAD --run-test 0
issue #<id>
orfixes #<id>
where<id>
is the associated MantisBT issue id if one existsAnd please remember to update the Wiki with the features added or changed once this PR once it is merged.
Some testing required. Works well enough for my test cases, but they are fairly naive.
Supported methods (all booleans,
extrude
,mirror
,makeFillet2
,makeChamfer2
) now come with an optionalwithHistory
parameter that can be set toTrue
if you want to store history. The development of the sub-shapes from the sub-shapes of the base(s) can be studied by usingshapeName.History.modified
,shapeName.History.generated
,shapeName.History.isDeleted
.