Path: Refactor operations #929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlampert
force-pushed
the
refactor/path-area-op
branch
2 times, most recently
from
82d025b
to
bbb9eb6
Compare
…o support multiple shapes.
…mentation into PathAreaOpGui.
… depth calculation for ops with BaseGeometry into PathAreaOp.
…teData callbacks are called synchronously).
…e the list of locations visible - much better user experience
…ally do anything and 3 buttons is consistent with the BaseLocation dialog.
…sure how they get through but they should not cause an exception.
…avel and keep tool down to the interface - latter one is hidden since it currently doesn't seem to work.
mlampert
changed the title
mlampert
force-pushed
the
refactor/path-area-op
branch
from
bbb9eb6
to
c709bce
Compare
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big refactoring to consolidate common code of operations into base classes. It started out for operations based on Path.Area but then expanded to all other ops - except for Surface which I can't get to work (at all).
The ops functionality themselves have not changed - however the UI has for some of the operations. The UI now uses common elements in the same order, providing the same look and feel for all of them. Note that the "Operation" page itself hasn't changed for most ops.
There's still room for improvement but this refactor brings us a lot closer to a stable, maintainable code base.