Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch: more consistent object naming and labelling #9687

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented May 28, 2023

Following the example of Arch_Wall:

  • Fixed object name.

  • Default label is translatable.

  • Name argument should only be used for the label and not be translated.

  • Your Pull Request meets the requirements outlined in section 5 of CONTRIBUTING.md for a Valid PR


Following the example of Arch_Wall:
- Fixed object name.
- Default label is translatable.
- Name argument should only be used for the label and not be translated.
@github-actions github-actions bot added the WB Arch Related to the Arch Workbench label May 28, 2023
@yorikvanhavre
Copy link
Member

That's a good cleaning!!! Thanks a lot @Roy-043 !

@yorikvanhavre yorikvanhavre merged commit 65b63a7 into FreeCAD:master May 30, 2023
7 checks passed
@Roy-043 Roy-043 deleted the Arch-more-consistent-object-naming-and-labelling branch May 30, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Arch Related to the Arch Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants