Draft: Add macOS paths to importDWG.py #9830
Conversation
|
LGTM! |
| path = "/usr/bin/ODAFileConverter" | ||
| if os.path.exists(path) and os.path.isfile(path): | ||
| return path | ||
| else: # for macOS |
There was a problem hiding this comment.
There should be a check if macOS, else unknown system, same for other if-then-else statements...
There was a problem hiding this comment.
I disagree. Two reasons:
- FreeCAD officially only supports 3 operating system. Anybody who chooses a different OS is doing so at their own risk.
- The if-then-else statements only result in a default path which is then checked. So if an unkown OS is used and the suggested path does not exist there is no problem.
There was a problem hiding this comment.
Ok. Let’s say we disagree about programming practices.
There was a problem hiding this comment.
In any case I don't know what we would do right now on a system that is not mac, linux or windows... I think if someone comes up with a new config, then we see about what paths to use...
There was a problem hiding this comment.
@Roy-043 FreeBSD fixes are submitted to FreeCAD from time to time. So while it is unofficial, it still supported
https://github.com/search?q=repo%3AFreeCAD%2FFreeCAD%20freebsd&type=code
This PR adds adds handling of macOS paths to importDWG.py.
Paths taken from this forum topic:
https://forum.freecad.org/viewtopic.php?t=79125&start=10