Fix: initialise PRNG properly #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When configuring the library through rc_config_init, the PRNG is not initalised. On platforms with no /dev/urandom this might be a serious security issue because passwords are not properly protected anymore. So this commit introduces a new utility function rc_random which ensures, that the PRNG is initialised before the first call to random. This commit fixes #82 Signed-off-by: Marcel Patzlaff <m.patzlaff@pilz.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring the library through rc_config_init, the PRNG is not
initalised. On platforms with no /dev/urandom this might be a serious
security issue because passwords are not properly protected anymore.
So this commit introduces a new utility function rc_random which
ensures, that the PRNG is initialised before the first call to
random.
This commit fixes #82
Signed-off-by: Marcel Patzlaff m.patzlaff@pilz.de