Fix fr_value_box_cast_to_octets when dealing with non-numeric and non…

…-ip types.
FreeRADIUS · Dec 16, 2019 · 0fe902a · 0fe902a
1 parent 44d8122
commit 0fe902a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/lib/util/value.c b/src/lib/util/value.c
@@ -1731,10 +1731,13 @@ static inline int fr_value_box_cast_to_octets(TALLOC_CTX *ctx, fr_value_box_t *d
 	 */
 	case FR_TYPE_NUMERIC:
 		fr_value_box_hton(dst, src);	/* Flip any uint32 representations */
-		/* FALL-THROUGH */
+		bin = talloc_memdup(ctx, ((uint8_t const *)&dst->datum) + fr_value_box_offsets[src->type],
+				    fr_value_box_field_sizes[src->type]);
+		break;
 
 	default:
-		bin = talloc_memdup(ctx, ((uint8_t *)&dst->datum) + fr_value_box_offsets[src->type],
+		/* Not the same talloc_memdup call as above.  The above memdup reads data from the dst */
+		bin = talloc_memdup(ctx, ((uint8_t const *)&src->datum) + fr_value_box_offsets[src->type],
 				    fr_value_box_field_sizes[src->type]);
 		break;
 	}