don't check for existence of struct. it always exists

and clean up struct only if it was allocated
FreeRADIUS · Jun 17, 2019 · 2103d78 · 2103d78
1 parent c768132
commit 2103d78
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/modules/rlm_krb5/rlm_krb5.c b/src/modules/rlm_krb5/rlm_krb5.c
@@ -339,7 +339,7 @@ static rlm_rcode_t CC_HINT(nonnull) mod_authenticate(void *instance, REQUEST *re
 	memset(&client, 0, sizeof(client));
 
 	rcode = krb5_parse_user(&client, request, conn->context);
-	if (rcode != RLM_MODULE_OK) goto cleanup;
+	if (rcode != RLM_MODULE_OK) goto release;
 
 	/*
 	 *	Verify the user, using the options we set in instantiate
@@ -374,10 +374,9 @@ static rlm_rcode_t CC_HINT(nonnull) mod_authenticate(void *instance, REQUEST *re
 	}
 
 cleanup:
-	if (client) {
-		krb5_free_principal(conn->context, client);
-	}
+	krb5_free_principal(conn->context, client);
 
+release:
 #  ifdef KRB5_IS_THREAD_SAFE
 	fr_connection_release(inst->pool, conn);
 #  endif