better error messages for logfile. And use them in rlm_detail

FreeRADIUS · May 12, 2014 · 52c3d1d · 52c3d1d
1 parent 99194bb
commit 52c3d1d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/main/log.c b/src/main/log.c
@@ -933,7 +933,10 @@ int fr_logfile_open(fr_logfile_t *lf, char const *filename, mode_t permissions)
 		dir = talloc_strdup(lf, filename);
 		if (!dir) goto error;
 		p = strrchr(dir, FR_DIR_SEP);
-		if (!p) goto error;
+		if (!p) {
+			fr_strerror_printf("No '/' in '%s'", filename);
+			goto error;
+		}
 		*p = '\0';
 
 		/*
@@ -946,6 +949,8 @@ int fr_logfile_open(fr_logfile_t *lf, char const *filename, mode_t permissions)
 		if ((dirperm & 0006) != 0) dirperm |= 0001;
 
 		if (rad_mkdir(dir, dirperm) < 0) {
+			fr_strerror_printf("Failed to create directory %s: %s",
+					   dir, strerror(errno));
 			talloc_free(dir);
 			goto error;
 		}
@@ -1014,7 +1019,11 @@ int fr_logfile_open(fr_logfile_t *lf, char const *filename, mode_t permissions)
 	 */
 	lf->entries[i].last_used = now;
 	lf->entries[i].dup = dup(lf->entries[i].fd);
-	if (lf->entries[i].dup < 0) goto error;
+	if (lf->entries[i].dup < 0) {
+		fr_strerror_printf("Failed calling dup(): %s",
+				   strerror(errno));
+		goto error;
+	}
 
 	return lf->entries[i].dup;
 }

diff --git a/src/modules/rlm_detail/rlm_detail.c b/src/modules/rlm_detail/rlm_detail.c
@@ -376,7 +376,7 @@ static rlm_rcode_t CC_HINT(nonnull) detail_do(void *instance, REQUEST *request,
 
 	outfd = fr_logfile_open(inst->lf, buffer, inst->perm);
 	if (outfd < 0) {
-		RERROR("Couldn't open file %s: %s", buffer, fr_syserror(errno));
+		RERROR("Couldn't open file %s: %s", buffer, fr_strerror());
 		return RLM_MODULE_FAIL;
 	}