Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 8859 to 8559 #5345

Closed
wants to merge 2 commits into from

Conversation

simeononsecurity
Copy link

@simeononsecurity simeononsecurity commented Jun 21, 2024

Merge Request: Correct RFC Number from 8859 to 8559

Summary

This merge request corrects the RFC number from 8859 to 8559 in the attribute definition comments. RFC 8559 is the correct reference for the attribute Operator-NAS-Identifier.

Description

The following change has been made in the text header of the attribute definition file:

  • Changed RFC number from 8859 to 8559.

Changes

# -*- text -*-
# Copyright (C) 2019 The FreeRADIUS Server project and contributors
# This work is licensed under CC-BY version 4.0 https://creativecommons.org/licenses/by/4.0
#
-#        Attributes and values defined in RFC 8859
-#        http://www.ietf.org/rfc/rfc8859
+#        Attributes and values defined in RFC 8559
+#       https://datatracker.ietf.org/doc/html/rfc8559
#

ATTRIBUTE	Operator-NAS-Identifier			241.8	octets

Rationale

RFC 8559 is the correct reference document for the Operator-NAS-Identifier attribute. This correction ensures accurate documentation and helps prevent confusion for developers and contributors referencing the attribute definitions.

Testing

No functional code changes have been made, only comments have been corrected. Therefore, no additional testing is required.

Review

Please review the changes and approve the merge request if there are no issues.

mcnewton pushed a commit that referenced this pull request Jun 21, 2024
Change RFC 8859 to RFC 8559

Fixes #5345
@mcnewton
Copy link
Member

Pulled in manually. Thanks.

@mcnewton mcnewton closed this Jun 21, 2024
mcnewton pushed a commit that referenced this pull request Jun 21, 2024
Change RFC 8859 to RFC 8559

Fixes #5345
mcnewton added a commit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants