Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing pointer.SetPosition to corrected crash #3677

Merged
merged 1 commit into from
Jan 9, 2017

Conversation

alex7ce
Copy link
Contributor

@alex7ce alex7ce commented Jan 6, 2017

Crash happens if mouse pointer position changed programmatically.

@freerdp-bot
Copy link

Can one of the admins verify this patch?

Copy link
Member

@akallabeth akallabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bmiklautz
Copy link
Member

@freerdp-bot test.

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/1646/

@akallabeth
Copy link
Member

@freerdp-bot Oh come on, test properly

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/1647/

return FALSE;

return TRUE;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return context != NULL ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good tip, however, this is only a placeholder to prevent crash. So inside it there will be more code. It should probably move a cursor on a client machine appropriately.

@bmiklautz bmiklautz merged commit f53d035 into FreeRDP:master Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants