nsc: Fix memory leak #6320
Merged
nsc: Fix memory leak #6320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following memory leak: ==115716== 16,662,960 bytes in 459 blocks are definitely lost in loss record 3,504 of 3,504 ==115716== at 0x48396AF: malloc (vg_replace_malloc.c:306) ==115716== by 0x4C6A4E2: nsc_context_initialize_encode (nsc_encode.c:77) ==115716== by 0x4C6A4E2: nsc_compose_message (nsc_encode.c:497)
|
Can one of the admins verify this patch? |
|
@freerdp-bot test |
|
Refer to this link for build results (access rights to CI server needed): |
akallabeth
approved these changes
Jun 29, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following memory leak (found with valgrind):
==115716== 16,662,960 bytes in 459 blocks are definitely lost in loss record 3,504 of 3,504
==115716== at 0x48396AF: malloc (vg_replace_malloc.c:306)
==115716== by 0x4C6A4E2: nsc_context_initialize_encode (nsc_encode.c:77)
==115716== by 0x4C6A4E2: nsc_compose_message (nsc_encode.c:497)
I encountered this issue with the NSCodec implementation while working on https://gitlab.gnome.org/pnowack/gnome-remote-desktop/-/blob/initial-rdp-support/src/grd-session-rdp.c#L266)