codec/progressive: Allow the usage of multithreading for decoding #7036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking whether tiles and updatedTileIndices are both non-NULL, one of them might be NULL, while the other struct member might not be NULL and progressive_surface_context_new() leaks then the non-NULL struct member. Fix this by freeing both struct members, when aborting in progressive_surface_context_new(). free() will take no action on pointers that are NULL, so no additional check is needed.
|
Can one of the admins verify this patch? |
akallabeth
reviewed
May 25, 2021
akallabeth
approved these changes
May 25, 2021
While decoding RemoteFX encoded frames is multithreaded, decoding RemoteFX Progressive frames is not, although both codecs work relatively similarly. This is especially noticeable with frames, that have a resolution larger than 1920x1080 pixels. decompress_tile_first() and decompress_tile_upgrade() can both run in different threads at the same time for different tiles without necessary adjustments. So, do exactly that using the ThreadPool that already exists in the RFX_CONTEXT to decrease the decoding time and therefore increase the performance. On a 3K display (2880x1620 pixels) this makes out of a choppy experience a fluid experience.
pnowack
force-pushed
the
gfx-progressive-mthreaded
branch
from
f47ae23
to
e79fefe
Compare
akallabeth
approved these changes
May 25, 2021
|
@freerdp-bot test |
|
Refer to this link for build results (access rights to CI server needed): |
|
thanks for this fix, really appreciated :) |
This was referenced May 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting the main commit here:
This fixes a heavy performance regression with the RemoteFX Progressive codec, which the plain RemoteFX codec (when using the graphics pipeline) does not have.
I have tested this on top of the stable-2.0 branch using gnome-remote-desktop (uses TILE_SIMPLE) and Win10 (use TILE_FIRST + TILE_UPGRADE)