-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement BIO_CTRL_GET_KTLS_SEND and BIO_CTRL_GET_KTLS_SEND #7822
Conversation
Openssl 3.0 requires to respond to this controls. According to there documentation it should not need them, but in practice openssl's own source is full of places where negative return values are not checked.
Can one of the admins verify this patch? |
@freerdp-bot test |
@akarl10 thank you, was planning to look into this, you saved me a lot of debugging and reading into changes :) |
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
does indeed fix the gateway connection issue with current master and openssl3
@akarl10 since this looks like a bug in openssl3, did you report upstream or is it already known? |
@akarl10 thank you! |
@akallabeth I just opened openssl/openssl#18176 |
@akarl10 thank you. |
Openssl 3.0 requires to respond to this controls. According to there
documentation it should not need them, but in practice openssl's own source
is full of places where negative return values are not checked.
This is a fix for #7449