Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement BIO_CTRL_GET_KTLS_SEND and BIO_CTRL_GET_KTLS_SEND #7822

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Implement BIO_CTRL_GET_KTLS_SEND and BIO_CTRL_GET_KTLS_SEND #7822

merged 1 commit into from
Apr 25, 2022

Conversation

akarl10
Copy link
Contributor

@akarl10 akarl10 commented Apr 24, 2022

Openssl 3.0 requires to respond to this controls. According to there
documentation it should not need them, but in practice openssl's own source
is full of places where negative return values are not checked.

This is a fix for #7449

@akarl10
Implement BIO_CTRL_GET_KTLS_SEND and BIO_CTRL_GET_KTLS_SEND
9d7c20c 
Openssl 3.0 requires to respond to this controls. According to there
documentation it should not need them, but in practice openssl's own source
is full of places where negative return values are not checked.
@freerdp-bot
Copy link

Can one of the admins verify this patch?

@akallabeth akallabeth added this to the next milestone Apr 25, 2022
@akallabeth
Copy link
Member

@freerdp-bot test

@akallabeth
Copy link
Member

@akarl10 thank you, was planning to look into this, you saved me a lot of debugging and reading into changes :)

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/7392/

akallabeth
akallabeth approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@akallabeth akallabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
does indeed fix the gateway connection issue with current master and openssl3

@akallabeth akallabeth merged commit 4734c61 into FreeRDP:master Apr 25, 2022
@akallabeth akallabeth linked an issue Apr 25, 2022 that may be closed by this pull request
Connection over gateway doesn't work with OpenSSL 3.0 #7449
Closed
@akallabeth
Copy link
Member

@akarl10 since this looks like a bug in openssl3, did you report upstream or is it already known?

@akallabeth akallabeth mentioned this pull request Apr 25, 2022
Closed
@bmiklautz
Copy link
Member

@akarl10 thank you!

@akarl10 akarl10 deleted the rdp-gateway-openssl3-fix branch April 25, 2022 17:01
@akarl10
Copy link
Contributor Author

akarl10 commented Apr 25, 2022

@akarl10 since this looks like a bug in openssl3, did you report upstream or is it already known?

@akallabeth I just opened openssl/openssl#18176
I did not find any bug in this direction, so maybe we were the first to hit this issue

@akallabeth
Copy link
Member

@akarl10 thank you.
Maybe we´re using it wrong, but it might still be a good thing to have some (better) docs for return values ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akallabeth akallabeth akallabeth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-beta1
Development

Successfully merging this pull request may close these issues.

Connection over gateway doesn't work with OpenSSL 3.0
4 participants
@akarl10 @freerdp-bot @akallabeth @bmiklautz