Add support to send a ServerRedirection PDU #8252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
hardening
reviewed
Sep 27, 2022
hardening
approved these changes
Sep 27, 2022
|
@freerdp-bot test that please |
|
Refer to this link for build results (access rights to CI server needed): |
joantolo
force-pushed
the
send-server-redirection
branch
from
01815d1
to
ed40173
Compare
|
@freerdp-bot can you re test that ? |
|
Refer to this link for build results (access rights to CI server needed): |
akallabeth
reviewed
Sep 28, 2022
akallabeth
reviewed
Sep 28, 2022
akallabeth
reviewed
Sep 28, 2022
akallabeth
requested changes
Sep 28, 2022
joantolo
force-pushed
the
send-server-redirection
branch
from
ed40173
to
06a9105
Compare
joantolo
force-pushed
the
send-server-redirection
branch
from
06a9105
to
e35b032
Compare
|
@freerdp-bot test |
|
Refer to this link for build results (access rights to CI server needed): |
gnomesysadmins
pushed a commit
to GNOME/gnome-remote-desktop
that referenced
this pull request
Nov 4, 2023
This method will be used by daemon-system to send a server redirection PDU to a RDP client on handover process. To send the server redirection PDU it is using the recently merged method from FreeRDP: FreeRDP/FreeRDP#8252 .
gnomesysadmins
pushed a commit
to GNOME/gnome-remote-desktop
that referenced
this pull request
Nov 4, 2023
This method will be used by daemon-system to send a server redirection PDU to a RDP client on handover process. To send the server redirection PDU it is using the recently merged method from FreeRDP: FreeRDP/FreeRDP#8252 .
joantolo
added a commit
to joantolo/gnome-remote-desktop
that referenced
this pull request
Nov 23, 2023
This method will be used by daemon-system to send a server redirection PDU to a RDP client on handover process. To send the server redirection PDU it is using the recently merged method from FreeRDP: FreeRDP/FreeRDP#8252 .
joantolo
added a commit
to joantolo/gnome-remote-desktop
that referenced
this pull request
Nov 23, 2023
This method will be used by daemon-system to send a server redirection PDU to a RDP client on handover process. To send the server redirection PDU it is using the recently merged method from FreeRDP: FreeRDP/FreeRDP#8252 .
joantolo
added a commit
to joantolo/gnome-remote-desktop
that referenced
this pull request
Nov 24, 2023
This method will be used by daemon-system to send a server redirection PDU to a RDP client on handover process. To send the server redirection PDU it is using the recently merged method from FreeRDP: FreeRDP/FreeRDP#8252 .
joantolo
added a commit
to joantolo/gnome-remote-desktop
that referenced
this pull request
Nov 27, 2023
This method will be used by daemon-system to send a server redirection PDU to a RDP client on handover process. To send the server redirection PDU it is using the recently merged method from FreeRDP: FreeRDP/FreeRDP#8252 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should add the functionality of sending a Server Redirection PDU to a connected RDP client.
It has been implemented following the style of
core.redirection.I have tested with an xfreerdp client and recognises all fields properly. The client reconnects as expected.
I'm not sure if this method should be located in another place. It would be helpful if someone who knows more about this could point where it would make more sense to be located.
I assume this should be on the
stable-2.0branch too.Thank you.