Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client,common] skip invalid drives to redirect #9991

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

akallabeth
Copy link
Member

Fixes #9989: ignore invalid drive (=path) redirections from configuration, but notify the user with a warning message.

Fixes FreeRDP#9989: ignore invalid drive (=path) redirections from
configuration, but notify the user with a warning message.
@akallabeth akallabeth added this to the next-3.0 milestone Mar 18, 2024
@akallabeth akallabeth requested a review from mfleisz March 18, 2024 08:33
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11662/

invalid drive redirection paths are now ignored and no longer create an
error but just a warning message
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11663/

Copy link
Contributor

@hardening hardening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

@akallabeth akallabeth merged commit 622c688 into FreeRDP:master Mar 18, 2024
4 checks passed
@akallabeth akallabeth deleted the rdpdr_ignore_invalid branch March 18, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to load addins error when using RDP file which contains drivetoredirect:s
3 participants