Posix Port: Comment and remove unused variables #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cobusve
approved these changes
Dec 14, 2020
twpedersen
added a commit
to twpedersen/FreeRTOS-Kernel
that referenced
this pull request
Dec 17, 2020
Fixes: a48f137 ("Posix Port: Comment and remove unused variables (FreeRTOS#230)") The above commit introduced the compile error: /FreeRTOS/FreeRTOS/Source/portable/ThirdParty/GCC/Posix/port.c: In function ‘prvSetupSignalsAndSchedulerPolicy’: /FreeRTOS/FreeRTOS/Source/portable/ThirdParty/GCC/Posix/port.c:528:28: error: incompatible type for argument 3 of ‘pthread_sigmask’ *&xSchedulerOriginalSignalMask ); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /usr/include/signal.h:359, from FreeRTOS/FreeRTOS/Source/portable/ThirdParty/GCC/Posix/port.c:53: /usr/include/x86_64-linux-gnu/bits/sigthread.h:33:31: note: expected ‘__sigset_t * restrict’ {aka ‘struct <anonymous> * restrict’} but argument is of type ‘sigset_t’ {aka ‘struct <anonymous>’} __sigset_t *__restrict __oldmask)__THROW;
cobusve
pushed a commit
that referenced
this pull request
Jan 8, 2021
laroche
pushed a commit
to laroche/FreeRTOS-Kernel
that referenced
this pull request
Apr 18, 2024
* Make changes for MISRA rule 2.2 * Add comments to explain changes * Fix a typo * Actually fix a typo I missed a spot in the previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment and remove unused variables
Description
Removing an unused variable
Commenting 2 others as they are part of a commented code that was made in a certain way to be compatible with the demo timing requirements.
Do not cancel the idle task if FreeRTOS is compiled without an idle task
Related Issue
https://forums.freertos.org/t/posix-port-compile-issues/11323/4
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.