Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move ipFRAGMENT_OFFSET_BIT_MASK to FreeRTOS_IP_Private.h #171

Closed
wants to merge 1 commit into from

Conversation

hs2gh
Copy link
Contributor

@hs2gh hs2gh commented Jan 25, 2021

Also make ipFRAGMENT_OFFSET_BIT_MASK definition available for custom
ethernet drivers supporting IP packet pre-filtering.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Also make ipFRAGMENT_OFFSET_BIT_MASK definition available for custom
ethernet drivers supporting IP packet pre-filtering.
@hs2gh hs2gh requested a review from a team as a code owner January 25, 2021 16:19
@AniruddhaKanhere
Copy link
Member

Hello @hs2gh, thank you for this PR.

I see that you would like to move some macros to IP_Private.h, however, there is another PR from a different contributor that is doing almost the same thing that your PR does. I am afraid that this similar change will constitute a merge conflict in either your PR or theirs (whichever is merged later).

My suggestion would be, (of course, if you don't mind) to remove the macro-moving changes from your PR just because the other PR has made some changes related to the macros in various files. If they were to remove the macro change from their PR, then it would seem incomplete - and most probably break some projects. Your PR is equally important and I would like you to keep the changes adding a U to some macros.

Does that seem acceptable? I am fine either way.

Thanks again,
Aniruddha

P.S., you can contribute to the other PR as well directly (after asking the PR author of course). One PR may have more than one contributor after all.

@hs2gh
Copy link
Contributor Author

hs2gh commented Jan 29, 2021

@AniruddhaKanhere All changes are included in the Don't Fragment Flags patch. #179 thanks to evpopov :)

@hs2gh hs2gh closed this Jan 29, 2021
@hs2gh hs2gh deleted the eth_driver_filter branch January 29, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants