Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add missing keyboard shortcuts #2138

Open
1 task done
PAI5REECHO opened this issue Mar 19, 2022 · 14 comments
Open
1 task done

[Feature Request]: Add missing keyboard shortcuts #2138

PAI5REECHO opened this issue Mar 19, 2022 · 14 comments
Labels
E: ease of use improvement enhancement New feature or request player-related Player-related changes are currently on hold due to the ongoing player migration.

Comments

@PAI5REECHO
Copy link

Guidelines

  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem Description

Several keyboard shortcuts that work on the YouTube website video player are missing: https://support.google.com/youtube/answer/7631406

Proposed Solution

Add missing keybinds

Alternatives Considered

None

Issue Labels

ease of use improvement

Additional Information

No response

@PAI5REECHO PAI5REECHO added the enhancement New feature or request label Mar 19, 2022
@PrestonN PrestonN added this to To assign in Feature Requests Mar 19, 2022
@vallode
Copy link
Contributor

vallode commented Mar 21, 2022

I compiled a list of the keyboard shortcuts provided for reference, @PAI5REECHO do you have any particular shortcuts in mind that you would prioritise?

Keyboard shortcut Supported
Spacebar Yes ✔️
Play/Pause Media Key on keyboards Yes ✔️ (Tested by @smcclennon)
k Yes ✔️
m Yes ✔️
Stop Media Key on keyboards Untested
Next/previous Track Media Key on keyboards Yes merged in #2239 ✔️
Left/Right arrow on the seek bar Yes (Seeks 10 seconds instead of the 5 on Youtube) ✅
j Yes ✔️
l Yes ✔️
. Yes ✔️
, Yes ✔️
> No (skips to next frame, should speed up playback) ❌
< No (skips to last frame, should slow down playback) ❌
Home/End on the seek bar No (scrolls page, should seek to start/end of video) ❌
Up/Down arrow on the seek bar Yes ✔️
Numbers 1 to 9 on the seek bar (not on the numeric pad) Yes ✔️
Number 0 on the seek bar (not on the numeric pad) Yes ✔️
/ Yes (ALT + D instead of /) merged in #2140 ✔️
f Yes ✔️
c Yes ✔️
Shift+N No (Should move to the next video. If you're using a playlist, will go to the next video of the playlist. If not using a playlist, it will move to the next YouTube suggested video) ❌
Shift+P No (Should move to the previous video. Note that this shortcut only works when you're using a playlist) ❌
i Yes merged in #2141 ✔️

@smcclennon
Copy link

  • The Play/Pause media key works.
  • The Next/Previous media keys do nothing, however this is the same behaviour as on YouTube.

In my opinion an essential missing keyboard shortcut is i, which enables the miniplayer on YouTube, and could instead enable picture-in-picture on FreeTube.

@vallode
Copy link
Contributor

vallode commented Mar 21, 2022

Seems like a good chunk of these shortcuts are covered by FreeTube just under a different key, I'll try to do some work to unify it a bit more. We should add a ? shortcut for a quick reference of all the shortcuts.

@smcclennon
Copy link

A keyboard shortcut to view all shortcuts would be very helpful. Other mainstream applications such as Signal and Element use the shortcut Ctrl+/ to do this.

@smcclennon
Copy link

Alternatively or in addition, keyboard shortcuts could be shown when a button is hovered over similarly to on YouTube.

For example, hovering over the theatre button on YouTube says (t)
image

@PrestonN
Copy link
Member

Just for reference, every shortcut we support is listed here.

As far as why some of them were different, there were concerns with the shortcuts that YouTube uses for those with Non US / Standard layouts. Keys like / and > are mapped differently and more difficult to press on these type of layouts. The alternative that we used for the search bar, Alt + D was picked because this was the shortcut that Firefox uses for focusing their search bar and was more accessible across layouts. Though having said this I see that #1463 is open so that should be looked at.

The interval that the video skips by when using the arrow keys is determined by your interval settings, 5 seconds is the default however.

Our existing shortcuts, save for possibly the stats for nerds shortcut, shouldn't be changed and any PR to do so will likely be closed. We do welcome any PR that happens to implement the few that we missed however.

@vallode
Copy link
Contributor

vallode commented Mar 21, 2022

What do we think of adding the shortcut keys into the popover text of buttons like @smcclennon mentioned? I think it would be a fairly easy change (happy to handle it) and it would make more people aware of keyboard shortcuts (lack of info is probably what caused this issue to be opened in the first place, as I was not aware we had all these shortcuts until delving into the codebase). Cheers.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 21, 2022

What do we think of adding the shortcut keys into the popover text of buttons like @smcclennon mentioned? I think it would be a fairly easy change (happy to handle it) and it would make more people aware of keyboard shortcuts (lack of info is probably what caused this issue to be opened in the first place, as I was not aware we had all these shortcuts until delving into the codebase). Cheers.

i would really like to see it
see #1587

@PAI5REECHO
Copy link
Author

do you have any particular shortcuts in mind that you would prioritise?

Mostly want < & > for speed up and slow down playback

@vallode
Copy link
Contributor

vallode commented Mar 23, 2022

Mostly want < & > for speed up and slow down playback

Currently these are bound to the O and P keys respectively (slow down and speed up). Waiting on overall response on having multiple shortcuts in #2140 so maybe we will bind the < > keys too :)

@WillyWonksters
Copy link

WillyWonksters commented Apr 6, 2022

do you have any particular shortcuts in mind that you would prioritise?

Mostly want < & > for speed up and slow down playback

This is the one I came here to file an issue about too. It is also the existing shortcut on Odysee.com, so this would bring consistency.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 8, 2022

Next Track Media Key on keyboards does work on YT but only in playlists. This doesnt work on FT yet.

@Pistos
Copy link

Pistos commented Oct 19, 2022

(These shortcuts will be added by #2698 )

@KevinReems
Copy link

Spacebar does not always toggle play/pause. It toggles whatever button was last clicked on with the mouse cursor. This is the same behavior as youtube but it's confusing and makes the spacebar useless.
Please make the spacebar Always toggle play/pause.

Also, no keyboard shortcuts work at all when the video itself does not have focus.

@kommunarr kommunarr added the player-related Player-related changes are currently on hold due to the ongoing player migration. label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: ease of use improvement enhancement New feature or request player-related Player-related changes are currently on hold due to the ongoing player migration.
Projects
Status: To assign
Development

No branches or pull requests

9 participants