Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Keyboard shortcut to toggle autoplay #4103 #4227

Closed
wants to merge 4 commits into from

Conversation

Hector118
Copy link

@Hector118 Hector118 commented Oct 24, 2023

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

This feature would be a nice work around for #1181 and another option to #2138 and https://docs.freetubeapp.io/usage/keyboard-shortcuts/
closes #4103

Description

"A" or "a" being the keyboard shortcut for the "Autoplay" toggle switch/slide button.

Desktop

  • OS: Ubuntu LTS Jammy Jellyfish
  • OS Version: 22.04
  • FreeTube version: 0.19.1

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 24, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 24, 2023 20:12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efb4f5ff-1298-471a-8973-3d47447115dc

Hi @Hector118 the team has decided to close the issue that led to this PR. That means this PR unfortunately, will also be closed.

Reasons for closing that issue are:

  • Autoplay is rarely toggled, so that removes the need for a shortcut to be there.
  • Integrating Autoplay into the video player removes the need for the shortcut.

We apologize for not clearly communicating in the earlier stages of the issue if this is something that the application needed.

Please don't take the closure of the PR in the wrong way because you did a very good job on it. We just failed to decide if this is something that is really needed.

Hopefully, we will see more contributions from you in the future :)

auto-merge was automatically disabled November 19, 2023 01:05

Pull request was closed

@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Keyboard shortcut to toggle autoplay
2 participants