Add missing keyboard shortcuts #2698

Aiz0 · 2022-10-10T01:31:52Z

Add missing keyboard shortcuts

Pull Request Type

Bugfix
Feature Implementation
Documentation
Other

Related issue

Description

According to #2138 there seems to be 2 missing shortcuts, 2 shortcuts that are already implemented but users want alternate bindings, and 2 shortcuts don't have any regular key binds, uses Media keys exclusively.

What's implemented

Home Jump to beginning of video
End Jump to end of video
< and > added as alternate shortcuts for controlling video playback rate.
Shift + N play next video in playlist or recommendations
Shift + P play previous video in playlist.

Shift + P can no longer be used to increase video playback rate

Alternate shortcuts

video playback rate

~~Should < and > be added as alternate keybinds to speed up / slow down video playback rate?~~
Implemented

playlist navigation

Youtube supports Shift + N and Shift + P to navigate to next / previous video in playlist.
Freetube already uses P to slow down playback rate.
Should we use some other keys for this?
Implemented

~~I could also try to add support for the media next playing next suggested video if not playing any playlist.~~
Implemented

Screenshots

no visible changes.

Testing

Home and end shortcuts

Go to a video.
Press End to Jump to the end of the video.
Press Home to Jump to the beginning of the video.

Playback rate shortcuts

Go to a video.
< and > to control playback rate

Playlist shortcuts

go to playlist video (link)
Press Shift + N to play next video in playlist
Press Shift + P to play previous video in playlist
you should also test if autoplay next works as expected.

Next Recommended videos shortcuts

Go to any video with hide recommended videos disabled

Press Shift + N to play next recommended video
you should also test if autoplay next works as expected

Nothing should happen if Hide recommended videos is enabled.

Desktop

OS: Arch Linux
OS Version: 5.19.13-arch1-1
FreeTube version: 0.17.1

Additional context

https://support.google.com/youtube/answer/7631406

efb4f5ff-1298-471a-8973-3d47447115dc · 2022-10-10T16:45:47Z

Alternate shortcuts

video playback rate

Should < and > be added as alternate keybinds to speed up / slow down video playback rate?

Yes please, we now have O and P for that but it would be nice if < and > would also do that. This makes it more uniform and familiar with the users of YT.

playlist navigation

Youtube supports Shift + N and Shift + P to navigate to next / previous video in playlist. Freetube already uses P to slow down playback rate. Should we use some other keys for this?

Im not sure if it would really matter because you are pressing SHIFT first. I would like it to behave the same as YT for the same reasons pointed out before.

I could also try to add support for the media next playing next suggested video if not playing any playlist.

That would indeed be nice!

Shift + N can now play next recommend video if not in playlist

Aiz0 · 2022-10-11T02:21:31Z

I've now added the other shortcuts

< and > added as alternate shortcuts for controlling video playback rate.
Shift + N and Shift + P can now be used navigate to next / previous video in playlist.
When not watching a playlist Shift + N will play next recommended video instead.

Shift + P can no longer be used to increase video playback rate

efb4f5ff-1298-471a-8973-3d47447115dc · 2022-10-11T08:03:51Z

Shift + P can no longer be used to increase video playback rate

Shift + P never did that P increased video playback rate. Do you maybe mean P?

Aiz0 · 2022-10-11T16:13:46Z

Shift + P never did that P increased video playback rate. Do you maybe mean P?

you could control video playback rate with lowercase and uppercase p
uppercase p is just shift + p or shift + P

src/renderer/views/Watch/Watch.js

PikachuEXE

Tested most except
Home and end shortcuts (MacOS)

absidue · 2022-10-13T08:39:16Z

Tested most except Home and end shortcuts (MacOS)

according to this article you can use Fn+Left arrow for Home and Fn+Right arrow for End

PikachuEXE · 2022-10-14T01:59:39Z

Still can't get it to work ._.
Might need people with windows to test

github-actions · 2022-10-14T06:01:19Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

src/renderer/components/ft-video-player/ft-video-player.js

src/renderer/views/Watch/Watch.js

…into add-missing-shortcuts

Forgot about this somehow. Prevents a error from appearing in console when using shortcut while not watching a playlist. I did notice a seperate error appears if on first video.

Requires you to press Shift when Caps Lock is enabled. Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>

efb4f5ff-1298-471a-8973-3d47447115dc · 2022-10-22T21:31:00Z

Ready for review?

Aiz0 · 2022-10-22T21:44:50Z

bug needs fix first.
cant use < > because they use shift to be typed on most layouts

absidue · 2022-10-23T14:41:30Z

@Aiz0 You can fix that by not returning at the top when shift is pressed, you only need to check that shift is pressed for specific shortcuts, for others it's fine if shift is pressed or not.

- Alphanumeric keys don't work when shift is held, they still work when capslock is enabled - By using toLowerCase(), Only one case per key is required instead of one for upper and one for lowecase. - The check for shift does not simply return anymore. additional switch statements can be added for shifted keys. Having a seperate switch statement is in my opinion better than having checking for shift on each shortcut. - Keys that require shift to be typed put into seperate switch statement. lmaooooooooooooooooooooooooooooooooooooooooooooooooooooooo :[ :(

simplefies things and shouldn't cause any issues as far as i'm aware

second switch statement now only includes keys with names longer than a single character

PikachuEXE · 2022-11-02T02:36:31Z

src/renderer/views/Watch/Watch.js

+      if (event.ctrlKey || document.activeElement.classList.contains('ft-input') || !event.shiftKey) {
+        return
+      }
+      switch (event.key.toUpperCase()) {


Why we use switch (event.key.toLowerCase()) { above but toUpperCase here ?_?
No an issue for me though, just curious

github-actions · 2022-11-04T07:23:33Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

ChunkyProgrammer · 2022-11-04T23:00:47Z

Did you mean to close this PR? @Aiz0

Add video player Home/End shortcuts

e17d5d2

github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 10, 2022

Aiz0 changed the title ~~Add missing keyboard shortcuts~~ WIP: Add missing keyboard shortcuts Oct 10, 2022

Aiz0 added 4 commits October 11, 2022 02:42

add alternate video playback rate shortcuts

28d2ba5

add shortcuts to control playlist

0f8c80a

add shortcut for playing next recommended video

f9c108f

move playlist shortcuts to Watch.js

baddf0e

Shift + N can now play next recommend video if not in playlist

Aiz0 marked this pull request as ready for review October 11, 2022 02:23

Aiz0 changed the title ~~WIP: Add missing keyboard shortcuts~~ Add missing keyboard shortcuts Oct 11, 2022

absidue reviewed Oct 11, 2022

View reviewed changes

src/renderer/views/Watch/Watch.js Outdated Show resolved Hide resolved

fix function name not starting with lowercase character

1eca6f3

FreeTubeBot enabled auto-merge (squash) October 11, 2022 21:05

ChunkyProgrammer requested review from absidue, PikachuEXE, ChunkyProgrammer and efb4f5ff-1298-471a-8973-3d47447115dc October 13, 2022 03:01

PikachuEXE reviewed Oct 13, 2022

View reviewed changes

github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Oct 14, 2022

ChunkyProgrammer reviewed Oct 14, 2022

View reviewed changes

src/renderer/components/ft-video-player/ft-video-player.js Show resolved Hide resolved

src/renderer/views/Watch/Watch.js Outdated Show resolved Hide resolved

src/renderer/views/Watch/Watch.js Outdated Show resolved Hide resolved

Aiz0 added 2 commits October 15, 2022 03:19

Merge branch 'development' of https://github.com/FreeTubeApp/FreeTube …

4981748

…into add-missing-shortcuts

add conditional to playlist shortcut

e5b2fef

Forgot about this somehow. Prevents a error from appearing in console when using shortcut while not watching a playlist. I did notice a seperate error appears if on first video.

auto-merge was automatically disabled October 15, 2022 01:34
Head branch was pushed to by a user without write access

Check for shift key on next/previous shortcuts

b7b29fc

Requires you to press Shift when Caps Lock is enabled. Co-authored-by: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>

FreeTubeBot enabled auto-merge (squash) October 22, 2022 15:48

shif keyt

0536c04

auto-merge was automatically disabled October 22, 2022 21:05
Head branch was pushed to by a user without write access

FreeTubeBot enabled auto-merge (squash) October 22, 2022 21:05

Aiz0 added 2 commits October 23, 2022 17:38

require shift for < and > shortcuts

160c9a8

simplefies things and shouldn't cause any issues as far as i'm aware

auto-merge was automatically disabled October 29, 2022 14:49
Head branch was pushed to by a user without write access

FreeTubeBot enabled auto-merge (squash) October 29, 2022 14:50

move , and . into first switch statement

3ef514b

second switch statement now only includes keys with names longer than a single character

auto-merge was automatically disabled October 29, 2022 15:01
Head branch was pushed to by a user without write access

FreeTubeBot enabled auto-merge (squash) October 29, 2022 15:01

ChunkyProgrammer added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Nov 1, 2022

ChunkyProgrammer requested review from PikachuEXE and ChunkyProgrammer November 1, 2022 12:15

PikachuEXE approved these changes Nov 2, 2022

View reviewed changes

ChunkyProgrammer approved these changes Nov 2, 2022

View reviewed changes

github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Nov 4, 2022

FreeTubeApp deleted a comment from github-actions bot Nov 4, 2022

Aiz0 closed this Nov 4, 2022

auto-merge was automatically disabled November 4, 2022 21:12
Pull request was closed

github-actions bot removed the PR: merge conflicts / rebase needed label Nov 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing keyboard shortcuts #2698

Add missing keyboard shortcuts #2698

Aiz0 commented Oct 10, 2022 •

edited

Loading

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 10, 2022

Alternate shortcuts

video playback rate

playlist navigation

Aiz0 commented Oct 11, 2022

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 11, 2022

Aiz0 commented Oct 11, 2022

PikachuEXE left a comment

absidue commented Oct 13, 2022

PikachuEXE commented Oct 14, 2022

github-actions bot commented Oct 14, 2022

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 22, 2022 •

edited

Loading

Aiz0 commented Oct 22, 2022

absidue commented Oct 23, 2022 •

edited

Loading

PikachuEXE Nov 2, 2022

github-actions bot commented Nov 4, 2022

ChunkyProgrammer commented Nov 4, 2022

Add missing keyboard shortcuts #2698

Add missing keyboard shortcuts #2698

Conversation

Aiz0 commented Oct 10, 2022 • edited Loading

Add missing keyboard shortcuts

Pull Request Type

Related issue

Description

What's implemented

Alternate shortcuts

video playback rate

playlist navigation

Screenshots

Testing

Home and end shortcuts

Playback rate shortcuts

Playlist shortcuts

Next Recommended videos shortcuts

Desktop

Additional context

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 10, 2022

Alternate shortcuts

video playback rate

playlist navigation

Aiz0 commented Oct 11, 2022

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 11, 2022

Aiz0 commented Oct 11, 2022

PikachuEXE left a comment

Choose a reason for hiding this comment

absidue commented Oct 13, 2022

PikachuEXE commented Oct 14, 2022

github-actions bot commented Oct 14, 2022

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 22, 2022 • edited Loading

Aiz0 commented Oct 22, 2022

absidue commented Oct 23, 2022 • edited Loading

PikachuEXE Nov 2, 2022

Choose a reason for hiding this comment

github-actions bot commented Nov 4, 2022

ChunkyProgrammer commented Nov 4, 2022

Aiz0 commented Oct 10, 2022 •

edited

Loading

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 22, 2022 •

edited

Loading

absidue commented Oct 23, 2022 •

edited

Loading