Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Video enters fullscreen when dragged from portait to landscape monitor #2806

Closed
4 tasks done
MarmadileManteater opened this issue Nov 3, 2022 · 0 comments · Fixed by #2808
Closed
4 tasks done
Labels
B: usability bug Something isn't working

Comments

@MarmadileManteater
Copy link
Contributor

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.

Describe the bug

When the window is dragged from a portrait monitor to a landscape monitor too quickly while a video is playing, the video will go full-screen.

Expected Behavior

The video should not enter full-screen when the window is dragged too quickly from a portrait display to a landscape display.

Issue Labels

usability issue

FreeTube Version

v0.18.0

Operating System Version

Windows 10 Pro Version 21H2 Installed on ‎4/‎3/‎2022 OS build 19044.1889 Experience Windows Feature Experience Pack 120.2212.4180.0

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

v0.17.1

Additional Information

This bug occurs because of the way that video-js-mobile-ui detects rotation.

This could be fixed by hiding this functionality behind a setting called Enter fullscreen on rotate. The default value for this setting would be false, and that alone would prevent this issue from happening. Users with multi-monitor setups would just leave the setting off, and users who have displays that can rotate, such as tablets or phones, can turn it on if they want.

Nightly Build

@MarmadileManteater MarmadileManteater added the bug Something isn't working label Nov 3, 2022
@FreeTubeBot FreeTubeBot added this to To assign in Bug Reports Nov 3, 2022
@FreeTubeBot FreeTubeBot removed this from To assign in Bug Reports Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: usability bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant