Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to toggle Enter fullscreen on rotate #2808

Conversation

MarmadileManteater
Copy link
Contributor

@MarmadileManteater MarmadileManteater commented Nov 3, 2022

Add setting to toggle Enter fullscreen on rotate

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #2806

Description

This PR adds a new setting called Enter fullscreen on display rotate. This setting defaults to false, and this should prevent the video from entering fullscreen when the window is dragged across multi-monitor setups with portrait and landscape displays because AFAIK there is no scenario where someone would have multiple monitors and want to have this setting on.

Screenshots

before:
before
after:
after

Testing

This can be tested on dual monitor setups with one portrait and one landscape display.

  1. Play a video
  2. Attempt to drag it from your portrait monitor to your landscape monitor
  3. Make sure it doesn't enter full screen mode unexpectedly

It would also probably be worth testing that the setting works when enabled:

  1. Enable Enter fullscreen on rotate under Player Settings
  2. Attempt to drag it from your portrait monitor to your landscape monitor
  3. Make sure it does enter fullscreen

Or, I guess if you are really trying to be thorough about it:

  1. yarn dev:web
  2. Access your local IP address at port 9080 from a browser on a phone or tablet connected to your network
  3. Enable Enter fullscreen on rotate under Player Settings
  4. Play a video
  5. Tap the video to ensure videojs-mobile-ui is active and working
  6. Attempt to rotate the display from portrait to landscape while the video is playing
  7. Make sure that the video enters fullscreen

Desktop

  • OS: Windows 10
  • OS Version: Pro Version 21H2 Installed on ‎4/‎3/‎2022 OS build 19044.1889 Experience Windows Feature Experience Pack 120.2212.4180.0
  • FreeTube version: 0.18.0

It defaults to `false`. This should prevent users with
multiple displays from running into issues when they
drag the window from a portrait display to a landscape
display too quickly.
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 3, 2022 03:12
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 3, 2022
@FreeTubeBot FreeTubeBot merged commit f8ff0e1 into FreeTubeApp:development Nov 4, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 4, 2022
@MarmadileManteater MarmadileManteater deleted the fullscreen-on-rotate-setting branch March 16, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Video enters fullscreen when dragged from portait to landscape monitor
5 participants