Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Captions shortcut c only works on DASH formats #3570

Closed
5 tasks done
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue May 21, 2023 · 0 comments · Fixed by #3580
Closed
5 tasks done

[Bug]: Captions shortcut c only works on DASH formats #3570

efb4f5ff-1298-471a-8973-3d47447115dc opened this issue May 21, 2023 · 0 comments · Fixed by #3580

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

videojs-http-streaming adds a "segment-metadata", text track at index 0
https://github.com/videojs/http-streaming#segment-metadata

Problematic lines, for DASH we need to use index 1, which is what we do here, but for non-DASH we need to use index 0

if (tracks[1].mode === 'showing') {

  1. Go to https://youtu.be/mBIdAMcvRhY
  2. Use DASH format
  3. Use shortcut c
  4. Works fine
  5. Switch to legacy or audio format
  6. Use shortcut c
  7. Doesnt work

Expected Behavior

Shortcut should work regarding what format is selected.

Issue Labels

inconsistent behavior, keyboard control not working, usability issue

FreeTube Version

3e543ae

Operating System Version

Win10 22H2

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant