Fix keyboard shortcut to toggle the captions #3580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
PikachuEXE
approved these changes
May 23, 2023
ChunkyProgrammer
approved these changes
May 23, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 23, 2023
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix keyboard shortcut to toggle the captions
Pull Request Type
Related issue
closes #3570
Description
Currently the keyboard shortcut to toggle the captions, only works for the DASH formats, this pull request makes it work for the audio and legacy formats too.
Testing
subtitles don't work on some Invidious instances, due to YouTube ratelimiting them, so best to test this with the local API
ckeyDesktop